feat(error): add error handling and rollback support#33
Merged
Conversation
- Wrap rename operation in try-catch - Track state to know if project was removed from solution - On failure, attempt to re-add project to solution at current path - Show failed step in progress dialog with error details - Display error message box with explanation Closes #13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds error handling with rollback support to prevent leaving the solution in a broken state.
Changes
projectRemovedFromSolution- true after project is removedprojectReaddedToSolution- true after project is re-addedRollback behavior
If an error occurs after the project is removed from the solution:
Test plan
Closes #13